,

Over the course of this year (from Jan to Sept), we have consistently been reducing the error rates of OpenShot Video Editor. Of course, our goal is 0% crashes, but we still have a ways to go. Version 2.4.0 is more than 2 times as stable as the previous version, and has been one of the most dramatic improvements in stability yet, but with your help, we can repeat this again, and keep doubling the stability with each release.

To get involved, please email me, and I will help you get everything building, and hopefully guide you in the right direction to tackle one of these bugs. I'll have your back, so nothing to fear, haha.

Below are the top C++ crashes (collected automatically for those who opt-in). These crashes happen in libopenshot, and are very likely related to race conditions caused by multiple threads. The format is [namespace::class::method frequency_score].

  • openshot::Timeline::ClearAllCache    938
  • openshot::CrashHandler::printStackTrace    534
  • openshot::Timeline::GetFrame    424
  • openshot::VideoCacheThread::run    200
  • openshot::PlayerPrivate::run    164
  • openshot::Timeline::add_layer    144
  • openshot::PlayerPrivate::getFrame    141
  • openshot::Clip::GetFrame    132
  • openshot::FFmpegReader::ReadStream    113
  • openshot::FFmpegReader::GetFrame    87
  • openshot::Timeline::find_intersecting_clips    86
  • openshot::Clip::Open    84
  • openshot::FrameMapper::Open    84
  • openshot::Timeline::update_open_clips    84
  • openshot::Clip::GetOrCreateFrame    83
  • openshot::FrameMapper::GetFrame    81
  • openshot::FFmpegReader::GetAVFrame    73
  • openshot::Timeline::add_layer::shared_ptr::Frame::Clip    71
  • openshot::FFmpegReader::Open    70
  • openshot::Timeline::ApplyMapperToClips    57

Below are the top Python crashes & errors (collected automatically for those who opt-in). These crashes happen in openshot-qt, and are caused by a variety of different factors. The format is [filename.py::line frequency_score].

  • json_data.py:148    818
  • main_window.py:565    783
  • project_data.py:704    783
  • json_data.py:143    773
  • main_window.py:2243    228
  • main_window.py:260    186
  • main_window.py:240    180
  • blender_listview.py:242    106
  • blender_listview.py:88    106
  • title_editor.py:581    101
  • timeline_webview.py:2797    93
  • video_widget.py:516    58

,

The latest and greatest version of OpenShot Video Editor (version 2.4.0) has been officially released, and I'm proud to bring you all the details! This is a stability-focused release, and much of the effort was "behind-the-scenes" type work.

Vastly improved stability, improved undo/redo history (now being saved inside each project file), new freeze and zoom menu, updated translations, and many bug fixes!

I have spent the past few months working along side a few other brave developers (huge thanks to Craig and Peter), determined to solve a very difficult stability issue, which is the leading cause of crashes in the OpenShot 2.x source code. The challenge was to isolate the crash, and find a way to reliably reproduce the crash in our development environments. This proved very difficult, and often we could run hours and hours of test code before a crash would happen. And of course, debuggers and analysis tools would slow the code down, and reduce the likelihood of a crash even more, often preventing the crash completely.

For those who want more technical details on the crash, please keep reading. The crash was a race condition and memory corruption bug, caused by a few different things. We process video and audio data in a thread pool, and sometimes things happen in a very unpredictable order. In a very rare condition, memory was being cleared while it was still being accessed. Also, we switched from an older tr1::shared_ptr to std::shared_ptr, and changed the way we initialize our shared_ptr instances, reducing the amount of memory being requested. Also, there were a few spots that needed to be protected between threads, and required locks. So, in summary, a handful of small changes, and a few months of debugging, and we can no longer crash libopenshot during video processing or video encoding! I'm very excited about solving this one if you can't tell!

Here is the full list of improvements:


openshot-qt (Video Editor)
  • Improving undo/redo support. Now the last X number of undo/redo actions are stored in the project file. The number can be adjusted in the prefences, under the auto-save tab. This also vastly improves the usefulness of the auto-save system, since it saves your undo/redo history as well.
  • Fixed Image Sequence exporting. Supports PNG, JPG, PPM, BMP and a few others. Also added 'Audio Only' and 'Video Only' export options.
  • Adding new Freeze and Freeze & Zoom presets, to quickly insert freezes into clips. 
  • Removing 'show waveform' from separate audio menu, to increase speed of separating audio. 
  • Protect file menu from invalid file_id.
  • Protect timeline dropEvent from empty item_id.
  • Cloaking timeline body until Angular loads fully (so we don't see the occasional pop-in debug layout).
  • Updating translations and supporters.
  • Bumping version to 2.4.0 (minimum libopenshot version 0.1.8).

libopenshot (Video Library)
  • Prevent crashes related to too many threads (on 24+ thread systems).
  • Migrating tr1 to std, adding C++11 support to build scripts, fixing crash in FFmpegReader (caused by shared_ptr, buffer, and last_video_frame corruption). Much improved stability with this change. Thanks to Craig and Peter for the help!
  • Fixing crash on Ubuntu build server.
  • Fixed a strange bug related to exporting image sequences. The filename property was not being set on the AVFormatContext. Also fixed a bug when exporting to JPEG image sequences related to max_b_frames and certain codecs.
  • Fixing issue with incorrect image size caches, which results in blurry/smudgy scaling on certain things.
  • Fix issue with loading time curves that are never processed (i.e. have no values)
  • Adding additional locks when adding/changing audio data. Reducing FrameMapper to a single frame at a time.
  • Fixing crash on Time keyframes where it would sometimes calculate an invalid frame number.
  • Fixing audio pops when stacking multiple clips with different offsets (pretty big issue for some people, just depending on your source framerates and position/start of clips).
  • Removing nested OMP processing from FrameMapper. Adding lock inside time mapping (to prevent crashes when speeding up/slowing down clips). Adding omp critial lock to Frame GetAudioChannelsCount() and GetAudioSamplesCount() methods.
  • Bumping version to 0.1.8 (SO version 13).

If you have had stability issues in the past with OpenShot 2.x, please give this latest version a try. Also, a big thanks to all the users, contributors, translators, and supporters that give life to this project! I could not do it on my own, and I am humbled that so many people find OpenShot useful. If you want to get involved with our project, please shoot me an email: jonathan@openshot.org. I am always happy to on-board new contributors and help them find something to help out with. Or if you would rather show your appreciation with a small donation, that would also be great!

Subscribe to: Posts (Atom)